Reorganise 'Certificate resource' page #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
inteon
force-pushed
the
rework_certificates_page
branch
from
59e3efe to
4e4fb9a
Compare
Signed-off-by: Tim Ramlot <[email protected]>
inteon
force-pushed
the
rework_certificates_page
branch
from
4e4fb9a to
a28df9e
Compare
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
|
Hey. I looked at the right menu, it seems OK to me: At first I was a bit confused by "Issuance triggers" vs. "Issuance behavior" but I could not think of any other way of presenting that. I am happy with the refactoring. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the structure of the 'Certificate resource' page.
One notable difference is the https://deploy-preview-1327--cert-manager-website.netlify.app/docs/usage/certificate/#reissuance-triggered-by-expiry-renewal section (that was actually talking about the different ways to trigger reissuance) is now moved and renamed to a "Reissuance triggered by user actions
" https://deploy-preview-1327--cert-manager-website.netlify.app/docs/usage/certificate/#reissuance-triggered-by-user-actions section in the new structure.
Other changes: grouped all the sections about the different Certificate properties in the "Creating Certificate Resources" section.
Before:
After: